ci: add coverage check #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mikix
force-pushed
the
mikix/coverage
branch
4 times, most recently
from
89115ee to
3476e83
Compare
dogversioning
approved these changes
Jul 8, 2024
| @@ -62,30 +62,11 @@ def confusion_matrix( | |||
| elif not truth_positive and not annotator_positive: | |||
| TN.append(key) | |||
| else: | |||
| raise Exception("Guard: Impossible comparison of reviewers") | |||
| raise Exception("Guard: Impossible comparison of reviewers") # pragma: no cover | |||
There was a problem hiding this comment.
i sort of think this could be deleted?
There was a problem hiding this comment.
I'm a little torn on that. I kind of agree with you - but I also think it's kind of nice to have a catch-all at end in case of future human error.
🤷 Arguably that's what tests are for...
But if I remove this, I'm also tempted to change the last elif to an else and losing that symmetry / self-documentation of the checks would be bad. So I'd probably keep it as a dangling elif which makes my hairs stand up a bit.
I dunno - I could be convinced since it is a pointless line. But maybe I need to sleep on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes some unused code, adds a few tests, and gets us to 100%.
Checklist
docs/) needs to be updated