Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add better error message for a bad config #59

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Nov 29, 2024

If you accidentally pass in the labelstudio export file as the config file (or just otherwise have a malformed config), this will give a nicer error message.

Also, clarify in the docs that ranges are inclusive.

Fixes: #56
Fixes: #57

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

If you accidentally pass in the labelstudio export file as the config
file (or just otherwise have a malformed config), this will give a
nicer error message.

Also, clarify in the docs that ranges are inclusive.
Copy link

github-actions bot commented Nov 29, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
696 695 100% 99% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chart_review/init.py 100% 🟢
chart_review/config.py 100% 🟢
TOTAL 100% 🟢

updated for commit: df5c0d3 by action🐍

@mikix mikix merged commit a35da46 into main Dec 2, 2024
5 checks passed
@mikix mikix deleted the mikix/tweaks branch December 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs should clarify that RANGE is inclusive Minor Bug: when specifying --config , response is invalid
2 participants