Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from black to ruff #61

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Switch from black to ruff #61

merged 1 commit into from
Feb 4, 2025

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Feb 4, 2025

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

Copy link

github-actions bot commented Feb 4, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
695 694 100% 99% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chart_review/agree.py 100% 🟢
chart_review/cli.py 100% 🟢
chart_review/cli_utils.py 100% 🟢
chart_review/cohort.py 98% 🟢
chart_review/commands/frequency.py 100% 🟢
chart_review/commands/labels.py 100% 🟢
chart_review/common.py 100% 🟢
chart_review/config.py 100% 🟢
chart_review/console_utils.py 100% 🟢
chart_review/external.py 100% 🟢
chart_review/simplify.py 100% 🟢
TOTAL 100% 🟢

updated for commit: aef22c0 by action🐍

Copy link

github-actions bot commented Feb 4, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
695 695 100% 99% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chart_review/agree.py 100% 🟢
chart_review/cli.py 100% 🟢
chart_review/cli_utils.py 100% 🟢
chart_review/cohort.py 100% 🟢
chart_review/commands/frequency.py 100% 🟢
chart_review/commands/labels.py 100% 🟢
chart_review/common.py 100% 🟢
chart_review/config.py 100% 🟢
chart_review/console_utils.py 100% 🟢
chart_review/external.py 100% 🟢
chart_review/simplify.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 58c1bbc by action🐍

@mikix mikix force-pushed the mikix/ruff branch 6 times, most recently from 507701a to c13a913 Compare February 4, 2025 18:32
Comment on lines -47 to +51
thresholdModified: 1
thresholdModified: .97
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inexplicably on Python 3.9 (only), there is one line of cohorts.py that isn't covered. When I added print() statements to debug this, the line was being hit... So I'm confused. But it's only hitting 3.9 - wonder if it's some old weird bug in coverage or something.

Anyway, since 3.9 is on its way out, I just lowered the threshold for now.

@mikix mikix merged commit 189eac1 into main Feb 4, 2025
6 checks passed
@mikix mikix deleted the mikix/ruff branch February 4, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants