-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated data package API, Ruff #120
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
log_level = os.environ.get("LAMBDA_LOG_LEVEL", "INFO") | ||
logger = logging.getLogger() | ||
logger.setLevel(log_level) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll centralize this at some point, but right now i'm mostly focused on just getting dashboard development unblocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This format change is the new structure - this is what @vlad-ignatov requested to help populate the subscription metadata.
src/handlers/shared/functions.py
Outdated
for k, v in extra_items.items(): | ||
data_version_metadata[k] = v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: data_version_metadata.update(extra_items)
might be more obvious that this is just a merge.
column_dict[column] = "float" | ||
column_dict[column] = "boolean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this a typo before? or some historical thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo from before
This PR makes the following changes: