Updated data package API, Ruff #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
dogversioning
commented
Oct 2, 2024
Comment on lines
+16
to
+19
| log_level = os.environ.get("LAMBDA_LOG_LEVEL", "INFO") | ||
| logger = logging.getLogger() | ||
| logger.setLevel(log_level) | ||
|
|
There was a problem hiding this comment.
I'll centralize this at some point, but right now i'm mostly focused on just getting dashboard development unblocked.
There was a problem hiding this comment.
This format change is the new structure - this is what @vlad-ignatov requested to help populate the subscription metadata.
mikix
approved these changes
Oct 2, 2024
src/handlers/shared/functions.py
Outdated
Comment on lines
143
to
144
| for k, v in extra_items.items(): | ||
| data_version_metadata[k] = v |
There was a problem hiding this comment.
nit: data_version_metadata.update(extra_items) might be more obvious that this is just a merge.
Comment on lines
-248
to
+253
| column_dict[column] = "float" | ||
| column_dict[column] = "boolean" |
There was a problem hiding this comment.
was this a typo before? or some historical thing
There was a problem hiding this comment.
Typo from before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes: