Skip to content

Commit

Permalink
ci: add a coverage check at end of unit tests
Browse files Browse the repository at this point in the history
It's currently set to require all new & modified code to be fully
covered. And to allow the current coverage score of 94% in general.
  • Loading branch information
mikix committed Jul 5, 2024
1 parent c8bd81b commit 6edba35
Showing 1 changed file with 15 additions and 4 deletions.
19 changes: 15 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,15 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
# while we are still private, don't go crazy with the Python versions as they eat up CI minutes
# Don't go crazy with the Python versions as the test suite is a beast.
# Just test the minimum version we support.
python-version: ["3.10"]

steps:
- uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

Expand Down Expand Up @@ -55,7 +56,17 @@ jobs:
- name: Test with pytest
run: |
python -m pytest
python -m pytest --cov-report xml --cov=cumulus_etl
- name: Generate coverage report
if: github.ref != 'refs/heads/main'
uses: orgoro/coverage@v3.1
with:
coverageFile: coverage.xml
token: ${{ secrets.GITHUB_TOKEN }}
thresholdAll: .94
thresholdNew: 1
thresholdModified: 1

nlp-regression:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -99,7 +110,7 @@ jobs:
echo "All Good!"
lint:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

Expand Down

0 comments on commit 6edba35

Please sign in to comment.