feat: use progress bars in a lot more places #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
commented
Aug 1, 2023
| @@ -136,37 +138,42 @@ async def _request_with_delay( | |||
| :param method: HTTP method to request | |||
| :returns: the HTTP response | |||
| """ | |||
| while self._total_wait_time < self._TIMEOUT_THRESHOLD: | |||
There was a problem hiding this comment.
This whole change is basically just an indent to support a new Status region with one Text field that we write the ongoing updates to, instead of just printing them to the console.
- Bulk export gets a spinner - Each task gets 3 progress bars (prep, batches, finalize) - After the ETL run, print a final success message
mikix
force-pushed
the
mikix/task-progress
branch
from
0103289
to
62c4f69
Compare
dogversioning
approved these changes
Aug 1, 2023
| failed = any(s.success < s.attempt for s in summaries) | ||
| if failed: | ||
| print("** One or more tasks above did not 100% complete! **", file=sys.stderr) | ||
| print("🚨 One or more tasks above did not 100% complete! 🚨", file=sys.stderr) |
There was a problem hiding this comment.
I literally can't believe I didn't start with those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old vs New
Old:
New:
Multiple Output tables
Bulk Progress Spinner
Screencast of New
Screencast.from.08-01-2023.11.14.32.AM.webm
Checklist
docs/) needs to be updated