feat: skip MS tool de-id for solo NLP task runs #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
mikix/skip-ms-tool-for-nlp
branch
from
8951d75
to
a6cc336
Compare
dogversioning
approved these changes
Aug 15, 2023
If an ETL run is only for an NLP task, the MS tool de-identification is unnecessary. The NLP task only pulls out certain bits of the incoming resources and still does the standard ID scrubbing itself. So it's just wasted time, especially since NLP tasks are frequently run by themselves as a separate GPU run.
mikix
force-pushed
the
mikix/skip-ms-tool-for-nlp
branch
from
a6cc336
to
b44a19f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ETL run is only for an NLP task, the MS tool de-identification is unnecessary. The NLP task only pulls out certain bits of the incoming resources and still does the standard ID scrubbing itself.
So it's just wasted time, especially since NLP tasks are frequently run by themselves as a separate GPU run.
Checklist
docs/) needs to be updated