-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart-review): group notes by encounter, show real & anon IDs #274
Conversation
1b5e98a
to
0eeead4
Compare
"For more information check: https://httpstatuses.com/400" | ||
"For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but httpx changed its output format. Maybe we should be more resilient to that, but part of me likes the strictness and doesn't mind updating once in a blue moon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly i don't hate it either, and that's probably a better source for that info anyway.
760a188
to
6247f62
Compare
cumulus_etl/chart_review/cli.py
Outdated
We also add little headers to each note with the Real & Anonymized docref IDs, to help reviewers. | ||
We've found that reviewers appreciate both practices. | ||
""" | ||
big_notes = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion, feel free to disregard (especially because, i, personally, find BIG NOTES hilarious for reasons): concatenated_notes might be more descriptive? this trickles down through the rest of this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 I changed the big_
prefix in this method to grouped_
which felt easier to say and matches the function name too (group_notes_by_encounter
).
"For more information check: https://httpstatuses.com/400" | ||
"For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly i don't hate it either, and that's probably a better source for that info anyway.
This adds a couple quality-of-life improvements to chart-review mode: - Notes are now grouped by encounter, with each note clearly demarked inside a larger text document. - Notes now have a header with their note type label (e.g. "Admission MD") - The encounter ID (real+anon) plus all the contained DocRef IDs (real+anon) are also pushed as Label Studio metadata, which will show up in exports if folks want to do some post-processing.
6247f62
to
9f02038
Compare
This adds a couple quality-of-life improvements to chart-review mode:
This should land along with an announcement.
Checklist
docs/
) needs to be updated