fix: guard against accidental deletes with ndjson output format #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ndjson output formatter deletes all existing content in its target directory, because it is not an incremental formatter. But this introduces the possibility of accidentally using the ndjson output format on a delta lake folder or some other important folder. So this commit checks the contents of the target output dir and errors out if there are odd looking files in there.
mikix
force-pushed
the
mikix/ndjson-safety
branch
from
f10e6a2
to
edd2b04
Compare
dogversioning
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ndjson output formatter deletes all existing content in its target directory, because it is not an incremental formatter.
But this introduces the possibility of accidentally using the ndjson output format on a delta lake folder or some other important folder.
So this commit checks the contents of the target output dir and errors out if there are odd looking files in there.
This fixes #280
Checklist
docs/) needs to be updated