feat(upload-notes): add ability to tag philter spans, not redact them #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
approved these changes
Feb 29, 2024
| parser.add_argument( | ||
| "--no-philter", action="store_false", dest="philter", default=True, help="Don’t run philter on notes" | ||
| "--no-philter", action="store_const", const=PHILTER_DISABLE, dest="philter", help=argparse.SUPPRESS |
There was a problem hiding this comment.
very kind of you, but i think you could make a breaking change now.
There was a problem hiding this comment.
Eh, I like to give some amount of gracetime, even to ourselves and our own muscle memory. But I've added a note that the arg can be removed after May 2024, to help avoid it staying around forever.
This commit deprecates --no-philter in favor of --philter=disable and adds --philter=label (and the default --philter=redact). When --philter=label is requested, we send a prediction layer to Label Studio that highlights all the detected PHI spans for you. This is helpful when doing manual de-identification, since philter can do some of the grunt work for you.
mikix
force-pushed
the
mikix/philter-labels
branch
2 times, most recently
from
4ab9528
to
943cb3c
Compare
mikix
force-pushed
the
mikix/philter-labels
branch
from
943cb3c
to
90d2d51
Compare
|
OK tests fixed after adjusting to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates --no-philter in favor of --philter=disable and adds --philter=label (and the default --philter=redact).
When --philter=label is requested, we send a prediction layer to Label Studio that highlights all the detected PHI spans for you.
This is helpful when doing manual de-identification, since philter can do some of the grunt work for you.
Example (synthea note, no PHI here):
Checklist
docs/) needs to be updated