feat: use group-name/export-time from log file if present #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading ndjson from a folder, parse any sibling logs we find
for export info like group/time.
These are the current workflow assumptions this adds:
- There will be a log.ndjson or log.*.ndjson file in the given folder.
- There cannot be multiples (unless log.ndjson exists, in which case
we always use that)
- That log file will be for a single export.
- e.g. We will generally grab the last "kickoff" event and ignore
others.
mikix
force-pushed
the
mikix/completion2
branch
from
431ca9c
to
34c652f
Compare
dogversioning
approved these changes
Apr 17, 2024
| case "status_complete": | ||
| self._parse_status_complete(row) | ||
| except (KeyError, json.JSONDecodeError) as exc: | ||
| raise self.IncompleteLog(f"Error parsing '{path}'") from exc |
There was a problem hiding this comment.
suggestion: consider a MissingLog error?
There was a problem hiding this comment.
Ah that actually does exist (I used NoLogs), in the find method below (along with MultipleLogs).
Currently nothing actually distinguishes between these flavors of error. Maybe they will in the future, but 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading ndjson from a folder, parse any sibling logs we find for export info like group/time.
These are the current workflow assumptions this adds (but this is all still optional - no error will happen if a log doesn't exist):
Checklist
docs/) needs to be updated