fix: be more graceful when MS tool moves files underneath us #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It moves temporary files into their final place, and that might happen as we are trying to get the file size - so handle that exception.
Dtphelan1
approved these changes
May 20, 2024
| def _get_file_size_safe(path: str) -> int: | ||
| try: | ||
| return os.path.getsize(path) | ||
| except FileNotFoundError: |
There was a problem hiding this comment.
(comment being written from an outsider's perspective, so forgive stupid questions plz)
Is this the right Error? The 3.12 docs I was looking at for os.path.getsize suggest it would throw OSError
There was a problem hiding this comment.
Ah yeah as we mentioned on slack, it's a builtin subclass of OSError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It moves temporary files into their final place, and that might happen as we are trying to get the file size - so handle that exception.
Checklist
docs/) needs to be updated