fix: allow the progress bars for reading ndjson to finish #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
commented
May 21, 2024
Comment on lines
+80
to
+81
| # See https://docs.delta.io/latest/delta-storage.html for advice | ||
| # on which version of hadoop-aws to use. |
There was a problem hiding this comment.
Unrelated, but I realized that 3.3.4 was kind of a magic number unless you knew where to look.
mikix
commented
May 21, 2024
Comment on lines
-240
to
+238
| if buf and buf[-1] != "\n": # catch a final line without a trailing newline | ||
| if buf and buf[-1] != ord("\n"): # catch a final line without a trailing newline |
There was a problem hiding this comment.
I forgot that buf was binary - this check never worked as intended, ahem
There was an off by one error if the last character of the ndjson file was a newline. This prevented some "reading" progress bars from every appearing finished. This was just cosmetic though - all data was read.
mikix
force-pushed
the
mikix/fix-progress-bar
branch
from
7079118
to
0a50986
Compare
mikix
commented
May 21, 2024
| @@ -153,14 +153,12 @@ def write_json(path: str, data: Any, indent: int = None) -> None: | |||
|
|
|||
|
|
|||
| @contextlib.contextmanager | |||
| # pylint: disable-next = contextmanager-generator-missing-cleanup | |||
There was a problem hiding this comment.
Unrelated, but also removed these disables - pylint fixed some false positives we were dealing with in their latest release: https://github.com/pylint-dev/pylint/releases/tag/v3.2.2
dogversioning
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an off by one error if the last character of the ndjson file was a newline. This prevented some "reading" progress bars from every appearing finished.
This was just cosmetic though - all data was read.
Checklist
docs/) needs to be updated