docs: add completion tables in our AWS template #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't necessarily used, but it's lightly helpful to have them already in place if you want to experiment with the completion tracking feature (--write-completion)
mikix
commented
Jul 2, 2024
Comment on lines
+201
to
+202
| - !Sub "s3://${S3Bucket}/${EtlSubdir}/etl__completion" | ||
| - !Sub "s3://${S3Bucket}/${EtlSubdir}/etl__completion_encounters" |
There was a problem hiding this comment.
Yes I removed these lines in the past to not confuse people - but that was because an empty crawler table was causing Library errors - I fixed that in smart-on-fhir/cumulus-library#236 so these should be safe to add back in.
dogversioning
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't necessarily used, but it's lightly helpful to have them already in place if you want to experiment with the completion tracking feature (--write-completion)
Checklist
docs/) needs to be updated