Parse any deleted resource IDs from bulk exports and act on it #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
changed the title
- It used to return common.Directory (which could be a TempDir) - It now includes a common.Directory plus completion tracking info like group name and export timestamp. - It will in future include metadata like a list of deleted IDs
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mikix
force-pushed
the
mikix/deleted-ids
branch
from
ce692de
to
9ba91a0
Compare
- When loading using the default ndjson loader, we look for a deleted/ folder and read any Bundle files there for deleted IDs - And then pass that along to tasks and matching formatters - Formatters now have a delete_records(ids) call - If the output format is deltalake, the IDs will be deleted
mikix
force-pushed
the
mikix/deleted-ids
branch
2 times, most recently
from
5ccd475
to
724ea10
Compare
mikix
changed the title
dogversioning
approved these changes
Sep 5, 2024
mikix
force-pushed
the
mikix/deleted-ids
branch
from
724ea10
to
9a6ab95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deletedmetadata on diskconvertlogic to read that preserved metadata and then carry that into the Delta LakeAs a reminder, the spec's commentary on how to handle
deletedis in the bulk export section.Fixes #167
Checklist
docs/) needs to be updated