fix(map): cluster problem #1172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `ShapeSource` component instead of `PointAnnotation` component to solve clustering bug in android - Added `clustersData` in `renderCluster` to create the desired data format of the `shape` in `ShapeSource` - added value 1000 to the `fitBounds` function to show the cluster in an animated way - updated with `parseInt` inside `handleClusterPress` since `cluster.id` is string in android SVA-1399
ardasnturk
force-pushed
the
fix/SVA-1399-fix-cluster-problem
branch
from
b1eaace
to
56344e1
Compare
donni106
reviewed
Jul 31, 2024
| type: 'FeatureCollection' | ||
| }; | ||
|
|
||
| markers.map((item) => { |
There was a problem hiding this comment.
you want to loop here, right, not map some value and return a new array? so please change to a loop over markers to update the values in clustersData.features
donni106
reviewed
Jul 31, 2024
donni106
reviewed
Jul 31, 2024
|
Stop this for now, clustering still not work properly, especially the display of the point counts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShapeSourcecomponent instead ofPointAnnotationcomponent to solve clustering bug in androidclustersDatainrenderClusterto create the desired data format of theshapeinShapeSourcefitBoundsfunction to show the cluster in an animated wayparseIntinsidehandleClusterPresssincecluster.idis string in androidSVA-1399
FIXME: point_count inside the cluster