fix: solve serial events display error in the list #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
- added `refetch` to refresh the data in the list after selecting any day from the calendar - added `fetchPolicy` for `refetch` to work - added `loading` control to the `data` props of `ListComponent` to show the user that the data has been refreshed SVA-665
ardasnturk
force-pushed
the
fix/SVA-665-solve-serial-events-display-error-in-the-list
branch
from
d59c910
to
a748914
Compare
- added +1 to `initialNumToRender` prop to fix index error in `SectionList` when date selected from calendar is changed SVA-665
donni106
reviewed
Jun 27, 2023
donni106
reviewed
Jun 28, 2023
donni106
reviewed
Jun 28, 2023
- added `fetchMoreData` function to load new data when scrolling to the bottom of the list - deleted `horizontal` and `showBackToTop` props because they are non-functional SVA-665
- removed the date information shown in the `subtitle` in the list below the calendar as it was redundant SVA-665
- adjusted the number of cells to be rendered initially, regardless of the size of the dataset, according to `MAX_INITIAL_NUM_TO_RENDER` SVA-665
donni106
approved these changes
Jun 30, 2023
ardasnturk
deleted the
fix/SVA-665-solve-serial-events-display-error-in-the-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refetchto refresh the data in the list after selecting any day from the calendarfetchPolicyforrefetchto workloadingcontrol to thedataprops ofListComponentto show the user that the data has been refreshedSVA-665