Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate custom links for android #857

Merged

Conversation

ardasnturk
Copy link
Member

@ardasnturk ardasnturk commented Jun 27, 2023

  • added withAndroidMailQueriesAndWhatsappPackage config for mailto: and whatsapp: custom link in webview to work on Android devices

SVA-1047

In order to run any custom link inside the webview, it is necessary to update the native files of Android. With Expo config-plugins, I updated the AndroidManifest.xml file in the Android folder (android/app/src/main/AndroidManifest.xml) so that the application can be redirected with mailto: and whatsapp: links.

I got help from the following issue.
React-Native Issue

To try it out:

  1. select branch and run yarn prebuild command
  2. connect the android device to the computer with the cable, run the yarn android -d command and select your device
  3. while waiting for the build to finish, perform the following actions
  4. change the settings prop of the StorySection component in NewsItem.js as follows.
settings={{ displayOnlySummary: 'true', onlySummaryLinkText: 'Weiterlesen' }}
  1. after the build process is successfully completed, follow these steps
  2. then enter the news "Test News mit Link"
  3. click on the "Weiterlesen" button
  4. you will see links for mail and whatsapp on the page that opens. you can try whether the feature works with these links.

@ardasnturk ardasnturk added the enhancement New feature or request label Jun 27, 2023
@ardasnturk ardasnturk added this to the 3.2.4 milestone Jun 27, 2023
@ardasnturk ardasnturk requested a review from donni106 June 27, 2023 09:58
@ardasnturk ardasnturk self-assigned this Jun 27, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jun 27, 2023

PR Summary

  • Configure Android Email and WhatsApp Packages
    Integration of Email and WhatsApp functionality in app configuration
  • New Android Mail Phone Queries
    Introduction of a new file to handle email and phone number queries for Android
  • New Android WhatsApp Package
    Addition of a new file dedicated to managing the WhatsApp package for Android

@github-actions github-actions bot added the codeball:approved Codeball label Jun 27, 2023
@donni106 donni106 modified the milestones: 3.2.4, 3.2.5 Jun 30, 2023
app.json Outdated Show resolved Hide resolved
config-plugins/withAndroidWhatsappPackage.js Outdated Show resolved Hide resolved
config-plugins/withAndroidWhatsappPackage.js Outdated Show resolved Hide resolved
@ardasnturk ardasnturk force-pushed the feature/SVA-1047-integrate-custom-links-for-android branch from 3863343 to 001f367 Compare July 3, 2023 10:45
- added `withAndroidMailQueriesAndWhatsappPackage` config for `mailto:` and `whatsapp:` custom
  link in webview to work on Android devices

SVA-1047
@ardasnturk ardasnturk force-pushed the feature/SVA-1047-integrate-custom-links-for-android branch from 001f367 to 7da4bc9 Compare July 3, 2023 10:48
@ardasnturk ardasnturk requested a review from donni106 July 3, 2023 10:49
@ardasnturk ardasnturk merged commit 956f495 into master Aug 1, 2023
1 check passed
@ardasnturk ardasnturk deleted the feature/SVA-1047-integrate-custom-links-for-android branch August 1, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeball:approved Codeball enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants