Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: autocomplete list not closing problem #859

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: autocomplete list not closing problem #859

merged 1 commit into from
Jun 29, 2023

Conversation

ardasnturk
Copy link
Member

@ardasnturk ardasnturk commented Jun 29, 2023 •
edited
Loading

  • updated height in flatListProps to undefined if city is selected to fix a bug where the AutoComplete list would remain open after a city search because height had not changed

SVA-833

before after
Simulator Screenshot - iPhone 14 Pro Max - 2023-06-29 at 16 14 28  Simulator Screenshot - iPhone 14 Pro Max - 2023-06-29 at 16 14 15

@ardasnturk ardasnturk added the bug Something isn't working label Jun 29, 2023
@ardasnturk ardasnturk added this to the 3.2.4 milestone Jun 29, 2023
@ardasnturk ardasnturk requested a review from donni106 June 29, 2023 14:12
@ardasnturk ardasnturk self-assigned this Jun 29, 2023
@ardasnturk ardasnturk changed the title fix autocomplete list not closing problem fix: autocomplete list not closing problem Jun 29, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jun 29, 2023

PR Summary

  • Modification in WasteCollectionScreen.js
    The PR includes a change to the display settings of the WasteCollectionScreen.js. Specifically, it adjusts the height property of the screen display based on whether a city has been selected in the input value. If a city is selected, the height remains default. If not, the height is reduced to fit within the specified dimension, allowing better screen space management.

@ardasnturk
fix: autocomplete list not closing problem
205fcd7 
- updated `height` in `flatListProps` to `undefined` if city is selected to fix a bug where the
  `AutoComplete` list would remain open after a city search because `height` had not changed

SVA-833
@ardasnturk ardasnturk force-pushed the fix/SVA-833-fix-the-problem-that-the-list-does-not-close-after-doing-a-city-search branch from 94d7385 to 205fcd7 Compare June 29, 2023 14:13
@ardasnturk ardasnturk merged commit f51e0ca into master Jun 29, 2023
1 of 2 checks passed
@ardasnturk ardasnturk deleted the fix/SVA-833-fix-the-problem-that-the-list-does-not-close-after-doing-a-city-search branch June 29, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donni106 donni106 donni106 approved these changes

Assignees

@ardasnturk ardasnturk

Labels
bug Something isn't working
Projects
None yet
Milestone
3.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ardasnturk @donni106