Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a space error between two inputs #861

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix: a space error between two inputs #861

merged 1 commit into from
Jul 4, 2023

Conversation

ardasnturk
Copy link
Member

  • added not to show the results if inputValueCitySelected is true to the city Autocomplete component to solve the problem of the space between the two inputs that occurs if there are more suggestions related to the selected city name after a place is selected from the city input

SVA-833

How to test:

  • Android
  • iOS
Android before Android after Android before Android after
Screenshot_20230704-112858 Screenshot_20230704-112802 Screenshot_20230704-112903 Screenshot_20230704-112808
iOS before iOS after iOS before iOS after
IMG_4106 IMG_4108 IMG_4107 IMG_4109

@ardasnturk
fix: a space error between two inputs
dba4688 
- added not to show the results if `inputValueCitySelected` is `true` to the city `Autocomplete`
  component to solve the problem of the space between the two inputs that occurs if there are more
  suggestions related to the selected city name after a place is selected from the city input

SVA-833
@ardasnturk ardasnturk added the bug Something isn't working label Jul 4, 2023
@ardasnturk ardasnturk added this to the 3.2.5 milestone Jul 4, 2023
@ardasnturk ardasnturk requested a review from donni106 July 4, 2023 09:33
@ardasnturk ardasnturk self-assigned this Jul 4, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 4, 2023

PR Summary

  • Enhancement in Waste Collection Screen
    Our team has added a new function called hideResults in the WasteCollectionScreen.js file. This function's value is set to mimic the status of inputValueCitySelected. It is used to control the display of search results in the waste collection page based on the user's input, enhancing our application's interactivity and user experience.

@donni106 donni106 modified the milestones: 3.2.5, 3.2.4 Jul 4, 2023
donni106
donni106 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@donni106 donni106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have marked it as part of 3.2.4, to not need a new release with versioning for this bugfix.

@ardasnturk ardasnturk merged commit d9807fc into master Jul 4, 2023
@ardasnturk ardasnturk deleted the fix/SVA-833-fix-a-space-error-between-two-inputs branch July 4, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donni106 donni106 donni106 approved these changes

Assignees

@ardasnturk ardasnturk

Labels
bug Something isn't working
Projects
None yet
Milestone
3.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ardasnturk @donni106