Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show alert after the survey is answered #865

Merged
merged 1 commit into from
Jul 12, 2023
Merged

feat: show alert after the survey is answered #865

merged 1 commit into from
Jul 12, 2023

Conversation

ardasnturk
Copy link
Member

  • added alert to submitSelection function to show alert after answering the survey
  • added new text to text file to show in alert

SVA-1059

before after
Simulator Screenshot - iPhone 14 - 2023-07-11 at 14 54 56 Simulator Screenshot - iPhone 14 - 2023-07-11 at 14 54 44

@ardasnturk ardasnturk added the enhancement New feature or request label Jul 11, 2023
@ardasnturk ardasnturk added this to the 3.2.5 milestone Jul 11, 2023
@ardasnturk ardasnturk requested a review from donni106 July 11, 2023 12:56
@ardasnturk ardasnturk self-assigned this Jul 11, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 11, 2023

PR Summary

  • New Alert Message Added
    A fresh entry has been placed in a file called texts.js, linked with a key named submitSuccess. This update is essentially introducing a new text for alerts in the system.

  • Implementation of New Alert in Survey
    In another file named surveyHooks.ts, the newly introduced alert, which corresponds to submitSuccess, has been implemented. This means when certain conditions in the survey are met, this specific alert message will be shown to the users.

@ardasnturk
feat: show alert after the survey is answered
23c0005 
- added alert to `submitSelection` function to show alert after answering the survey
- added new text to text file to show in alert

SVA-1059
@ardasnturk ardasnturk force-pushed the feature/SVA-1059-show-alert-after-the-survey-is-answered branch from 01f6060 to 23c0005 Compare July 12, 2023 12:55
@ardasnturk ardasnturk merged commit 91938b1 into master Jul 12, 2023
1 of 2 checks passed
@ardasnturk ardasnturk deleted the feature/SVA-1059-show-alert-after-the-survey-is-answered branch July 12, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donni106 donni106 donni106 approved these changes

Assignees

@ardasnturk ardasnturk

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ardasnturk @donni106