Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android crash #875

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix: android crash #875

merged 1 commit into from
Aug 1, 2023

Conversation

ardasnturk
Copy link
Member

  • updated releaseChannel in eas.json to channel so that the expo-updates package can work

SVA-1091

even if we don't use the expo-updates package, it needs to be configured to prevent the application from crashing on android.
in order for the expo-updates package to work with eas, the releaseChannel in eas.json had to be replaced with channel.
expo doc.: https://docs.expo.dev/build/updates/
expo doc.: https://docs.expo.dev/eas-update/eas-cli/?redirected

channel: The channel is a name we can give to multiple builds to identify them easily. Learn more
This field only applies to the EAS Update service, if your project still uses Classic Updates then use the releaseChannel field instead.

releaseChannel: Name of the release channel for the expo-updates package. Learn more
If you do not specify a channel, your binary will pull releases from the default channel. If you do not use expo-updates in your project then this property will have no effect.
This field only applies to the Classic Update service; if you use EAS Update, use the channel field instead.

after this update, the following line needs to be added to app.json when creating a build for the application.

"updates": { "url": "https://u.expo.dev/projectId" }

- updated `releaseChannel` in `eas.json` to `channel` so that the `expo-updates` package can work

SVA-1091
@ardasnturk ardasnturk added the bug Something isn't working label Jul 20, 2023
@ardasnturk ardasnturk added this to the 3.2.5 milestone Jul 20, 2023
@ardasnturk ardasnturk requested a review from donni106 July 20, 2023 12:41
@ardasnturk ardasnturk self-assigned this Jul 20, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 20, 2023

PR Summary

  • Update in Configuration File
    The configuration file, eas.json, had an update. The environment settings for production, preview, development, and development-simulator were revised. Specifically, the term releaseChannel has been updated to channel for clearer understanding.
  • New Addition for Testing Environments
    In the preview and development settings of the same configuration file, a new attribute named distribution has been added. It's currently set to "internal", which indicates these environments are intended for internal testing or previewing of the developed application before it's released for broader use.

@donni106
Copy link
Member

wow nice PR! thanks @ardasnturk.
the custom projectId in "updates": { "url": "https://u.expo.dev/projectId" } is needed for each release branch, right?

@ardasnturk
Copy link
Member Author

wow nice PR! thanks @ardasnturk.
the custom projectId in "updates": { "url": "https://u.expo.dev/projectId" } is needed for each release branch, right?

Yes, it is required for each release branch. 👍

@ardasnturk ardasnturk merged commit 8e08c2b into master Aug 1, 2023
1 check passed
@ardasnturk ardasnturk deleted the fix/SVA-1091-fix-android-crash branch August 1, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants