Skip to content

Add support for pinecone-v4 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for pinecone-v4 #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f8162
Add support for pinecone-v4
Jul 5, 2023
bc17901
Apply lint fix
Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions llama_index/vector_stores/pinecone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
)
from llama_index.vector_stores.utils import (
DEFAULT_TEXT_KEY,
legacy_metadata_dict_to_node,
metadata_dict_to_node,
node_to_metadata_dict,
legacy_metadata_dict_to_node,
)

ID_KEY = "id"
Expand Down Expand Up @@ -125,7 +125,6 @@ def __init__(
pinecone_index: Optional[Any] = None,
index_name: Optional[str] = None,
environment: Optional[str] = None,
namespace: Optional[str] = None,
insert_kwargs: Optional[Dict] = None,
add_sparse_vector: bool = False,
tokenizer: Optional[Callable] = None,
Expand All @@ -144,7 +143,6 @@ def __init__(

self._index_name = index_name
self._environment = environment
self._namespace = namespace
if pinecone_index is not None:
self._pinecone_index = cast(pinecone.Index, pinecone_index)
else:
Expand Down Expand Up @@ -207,7 +205,6 @@ def add(
entries.append(entry)
self._pinecone_index.upsert(
entries,
namespace=self._namespace,
batch_size=self._batch_size,
**self._insert_kwargs,
)
Expand All @@ -221,10 +218,8 @@ def delete(self, ref_doc_id: str, **delete_kwargs: Any) -> None:
ref_doc_id (str): The doc_id of the document to delete.

"""
# delete by filtering on the doc_id metadata
self._pinecone_index.delete(
filter={"doc_id": {"$eq": ref_doc_id}},
namespace=self._namespace,
ids=[ref_doc_id],
**delete_kwargs,
)

Expand Down Expand Up @@ -279,7 +274,6 @@ def query(self, query: VectorStoreQuery, **kwargs: Any) -> VectorStoreQueryResul
top_k=query.similarity_top_k,
include_values=True,
include_metadata=True,
namespace=self._namespace,
filter=filter,
**kwargs,
)
Expand Down