Add a new slider in graphics to select the quality (Potato, Fast and Fancy)#1188
Open
Bakoubak wants to merge 4 commits intosmartcmd:mainfrom
Open
Add a new slider in graphics to select the quality (Potato, Fast and Fancy)#1188Bakoubak wants to merge 4 commits intosmartcmd:mainfrom
Bakoubak wants to merge 4 commits intosmartcmd:mainfrom
Conversation
* Potato Mode for very low end devices, sets particules to minimal, graphics to fast and disables Ambient Occlusion. * Fast Mode for low/mid end devices, sets particules to decreased, graphics to fast with Ambient Occlusion. * Fancy Mode for mid/hight end devices, sets particules to maximum, graphics to fancy with Ambient Occlusion
Author
|
Here are the results: [Potato Mode] [Fast Mode] [Fancy Mode] |
Author
|
github seems to have mixed up every pictures... It goes from potato, fast to fancy. |
|
que versión usa Minecraft Legacy Edition |
Collaborator
|
why are all of the sliders just white |
Author
Im running on wine, it works fine on Proton-GE for some reason lmao |
Author
|
Added hot reload capabilities instead of having to leave everytime to apply the settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new slider in graphics to configure the current graphics level (Potato, Fast and Fancy)
(I think this supports the community guidelines, it is integrated in the code but never used and it is nice for peoples with older/weaker computers)
Previous Behavior
The game always assumed Fancy as the default
Root Cause
Graphics mode switching was never implemented and can be helpfull for older devices or weaker configurations.
New Behavior
Added a new slider in graphics to select the graphics quality
Fix Implementation
Added the slider in the SWF (Iggy), packed it in the .arc, then i added most of the code for this in the cpp side. Clouds are set to 2d for potato and fast, Leaves as fast for potato and fast, and ambient occlusion is disabled for potato.
AI Use Disclosure
The only use of AI here was to vibecode an arc opener/editor, and to understand how i was supposed to mess with the swf file. The code is authored only by myself.
Related Issues