Skip to content

Commit

Permalink
chore: decommission push-gha-metrics-action (#663)
Browse files Browse the repository at this point in the history
  • Loading branch information
erikburt authored Oct 10, 2024
1 parent 47894c1 commit dca9ab8
Show file tree
Hide file tree
Showing 36 changed files with 54 additions and 1,085 deletions.
35 changes: 35 additions & 0 deletions .changeset/fuzzy-planes-leave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
"cicd-build-publish-artifacts-go": patch
"cicd-build-publish-artifacts-ts": patch
"guard-from-missing-changesets": patch
"policy-bot-config-validator": patch
"helm-version-bump-receiver": patch
"cicd-build-publish-charts": patch
"cicd-build-publish-docker": patch
"llm-action-error-reporter": patch
"crib-purge-environment": patch
"slack-notify-git-ref": patch
"md-confluence-sync": patch
"ci-sonarqube-go": patch
"ci-sonarqube-ts": patch
"cicd-changesets": patch
"license-checker": patch
"ci-kubeconform": patch
"ci-lint-charts": patch
"manifest-build": patch
"pr-slack-alert": patch
"setup-nix-gati": patch
"update-actions": patch
"llm-pr-writer": patch
"ci-lint-misc": patch
"ci-prettier": patch
"ci-test-sol": patch
"ci-lint-go": patch
"ci-lint-ts": patch
"ci-test-go": patch
"ci-test-ts": patch
"setup-gap": patch
"nx-chainlink": patch
---

chore: remove metrics inputs and step (push-gha-metrics-action)
25 changes: 0 additions & 25 deletions .github/workflows/pull-request-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-lint
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

ci-prettier:
Expand All @@ -36,11 +31,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-prettier
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

ci-lint-misc:
Expand All @@ -54,11 +44,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-lint-misc
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}

cd-signed-commits:
# Disable this job until it's updated to be:
Expand Down Expand Up @@ -116,11 +101,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-test
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

ci-build-artifacts:
Expand All @@ -134,11 +114,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-build-artifacts
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

ci-actions-dependencies-updater:
Expand Down
28 changes: 1 addition & 27 deletions .github/workflows/push-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-lint
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

ci-prettier:
Expand All @@ -35,11 +30,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-prettier
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

ci-test:
Expand All @@ -53,11 +43,6 @@ jobs:
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: ci-test
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

cicd-build-publish-artifacts-dev:
Expand All @@ -78,13 +63,7 @@ jobs:
- name: cicd-build-publish-artifacts-dev
uses: ./actions/cicd-build-publish-artifacts-ts
with:
# general inputs
checkout-repo: "false"
# grafana inputs
metrics-job-name: cicd-build-publish-artifacts-dev
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"

cd-release:
Expand All @@ -103,15 +82,10 @@ jobs:
uses: ./actions/cicd-changesets
with:
# general inputs
pnpm-version: "^9.0.0"
git-user: app-token-issuer-releng-renovate[bot]
git-email: app-token-issuer-releng-renovate[bot]@users.noreply.github.com
# aws inputs
aws-region: ${{ secrets.AWS_REGION }}
aws-role-arn: ${{ secrets.AWS_OIDC_IAM_ROLE_ARN_GATI }}
aws-lambda-url: ${{ secrets.AWS_LAMBDA_URL_GATI }}
# grafana inputs
metrics-job-name: cd-release
gc-basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
gc-host: ${{ secrets.GRAFANA_INTERNAL_HOST }}
gc-org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
pnpm-version: "^9.0.0"
33 changes: 4 additions & 29 deletions .github/workflows/run-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -284,21 +284,21 @@ jobs:
image_versions="${{ github.sha }}"
else
image_versions+=",${{ github.sha }}"
fi
fi
fi
# Convert the comma-separated string to a JSON array
image_versions=$(echo "$image_versions" | jq -Rc 'if . == "" then "" else split(",") | if . == [""] then "" else . end end')
echo "Required Chainlink image versions: $image_versions"
echo "Required Chainlink image versions: $image_versions"
echo "versions=$image_versions" >> "$GITHUB_OUTPUT"
- name: Create matrix for required Chainlink plugin versions
id: set-required-chainlink-plugin-versions-matrix
shell: bash
run: |
image_versions=$(echo "${{ inputs.require_chainlink_plugin_versions_in_qa_ecr }}" | jq -Rc 'if . == "" then "" else split(",") | if . == [""] then "" else . end end')
echo "Required Chainlink plugin image versions: $image_versions"
echo "Required Chainlink plugin image versions: $image_versions"
echo "versions=$image_versions" >> "$GITHUB_OUTPUT"
check-test-configurations:
Expand Down Expand Up @@ -456,7 +456,7 @@ jobs:
echo "::error::Error: Some of the tests require custom test secrets to run. Please see workflow logs and set 'test_secrets_override_key' to run these tests."
exit 1
else
echo "No tests require secrets. Proceeding without additional secret setup."
echo "No tests require secrets. Proceeding without additional secret setup."
fi
- name: Generate random workflow id
Expand Down Expand Up @@ -573,19 +573,6 @@ jobs:
inputs.test_config_override_path }}
TEST_ID: ${{ matrix.tests.id_sanitized || matrix.tests.id }}
steps:
- name: Collect Metrics
if: always()
id: collect-gha-metrics
uses: smartcontractkit/push-gha-metrics-action@d9da21a2747016b3e13de58c7d4115a3d5c97935 # v3.0.1
with:
id: e2e_tests_${{ env.TEST_ID }}
org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
hostname: ${{ secrets.GRAFANA_INTERNAL_HOST }}
this-job-name: ${{ inputs.workflow_name }} / ${{ matrix.tests.id }}
test-results-file: '{"testType":"go","filePath":"/tmp/gotest.log"}'
continue-on-error: true

- name: Checkout repository
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
- name: Install jq
Expand Down Expand Up @@ -881,18 +868,6 @@ jobs:
inputs.test_config_override_path }}
TEST_ID: ${{ matrix.tests.id_sanitized || matrix.tests.id }}
steps:
- name: Collect Metrics
if: always()
id: collect-gha-metrics
uses: smartcontractkit/push-gha-metrics-action@d9da21a2747016b3e13de58c7d4115a3d5c97935 # v3.0.1
with:
id: e2e_tests_${{ env.TEST_ID }}
org-id: ${{ secrets.GRAFANA_INTERNAL_TENANT_ID }}
basic-auth: ${{ secrets.GRAFANA_INTERNAL_BASIC_AUTH }}
hostname: ${{ secrets.GRAFANA_INTERNAL_HOST }}
this-job-name: ${{ inputs.workflow_name }} / ${{ matrix.tests.id }}
continue-on-error: true

- name: Checkout repository
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
- name: Install jq
Expand Down
31 changes: 0 additions & 31 deletions actions/ci-kubeconform/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,25 +39,6 @@ inputs:
description: "charts directory"
required: true
default: "charts"
# grafana inputs (optional)
metrics-job-name:
description: "grafana metrics job name"
required: false
metrics-id:
description:
"grafana metrics id, used for continuity of metrics during job name
changes - required if metrics-job-name is passed"
required: false
gc-host:
description: "grafana hostname - required if metrics-job-name is passed"
required: false
gc-basic-auth:
description: "grafana basic auth - required if metrics-job-name is passed"
required: false
gc-org-id:
description:
"grafana org/tenant id - required if metrics-job-name is passed"
required: false

runs:
using: composite
Expand Down Expand Up @@ -101,15 +82,3 @@ runs:
run: |
helm dependency build
helm template . | kubeconform -kubernetes-version ${{ inputs.kubernetes-version }} ${{ env.STRICT }} ${{ env.IGNORE_MISSING_SCHEMAS }} ${{ env.SUMMARY }}
- name: Collect metrics
if: always() && inputs.metrics-job-name != ''
id: collect-gha-metrics
uses: smartcontractkit/push-gha-metrics-action@d9da21a2747016b3e13de58c7d4115a3d5c97935 # v3.0.1
with:
id: ${{ inputs.metrics-id || inputs.metrics-job-name }}
basic-auth: ${{ inputs.gc-basic-auth }}
hostname: ${{ inputs.gc-host }}
org-id: ${{ inputs.gc-org-id}}
this-job-name: ${{ inputs.metrics-job-name }}
continue-on-error: true
31 changes: 0 additions & 31 deletions actions/ci-lint-charts/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,6 @@ inputs:
description: "charts directory"
required: false
default: "charts"
# grafana inputs (optional)
metrics-job-name:
description: "grafana metrics job name"
required: false
metrics-id:
description:
"grafana metrics id, used for continuity of metrics during job name
changes - required if metrics-job-name is passed"
required: false
gc-host:
description: "grafana hostname - required if metrics-job-name is passed"
required: false
gc-basic-auth:
description: "grafana basic auth - required if metrics-job-name is passed"
required: false
gc-org-id:
description:
"grafana org/tenant id - required if metrics-job-name is passed"
required: false

runs:
using: composite
Expand Down Expand Up @@ -74,15 +55,3 @@ runs:
CHART_TESTING_EXTRA_ARGS: ${{ inputs.chart-testing-extra-args }}
run: |
ct lint --config "${CHART_TESTING_CONFIG_PATH}" "${CHART_TESTING_EXTRA_ARGS}"
- name: Collect metrics
if: always() && inputs.metrics-job-name != ''
id: collect-gha-metrics
uses: smartcontractkit/push-gha-metrics-action@d9da21a2747016b3e13de58c7d4115a3d5c97935 # v3.0.1
with:
id: ${{ inputs.metrics-id || inputs.metrics-job-name }}
basic-auth: ${{ inputs.gc-basic-auth }}
hostname: ${{ inputs.gc-host }}
org-id: ${{ inputs.gc-org-id}}
this-job-name: ${{ inputs.metrics-job-name }}
continue-on-error: true
31 changes: 0 additions & 31 deletions actions/ci-lint-go/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,25 +63,6 @@ inputs:
go-directory:
description: ""
default: .
# grafana inputs (optional)
metrics-job-name:
description: "grafana metrics job name"
required: false
metrics-id:
description:
"grafana metrics id, used for continuity of metrics during job name
changes - required if metrics-job-name is passed"
required: false
gc-host:
description: "grafana hostname - required if metrics-job-name is passed"
required: false
gc-basic-auth:
description: "grafana basic auth - required if metrics-job-name is passed"
required: false
gc-org-id:
description:
"grafana org/tenant id - required if metrics-job-name is passed"
required: false

runs:
using: composite
Expand Down Expand Up @@ -149,15 +130,3 @@ runs:
with:
name: golangci-lint-report
path: ${{ inputs.go-directory }}/golangci-lint-report.xml

- name: Collect metrics
if: always() && inputs.metrics-job-name != ''
id: collect-gha-metrics
uses: smartcontractkit/push-gha-metrics-action@d9da21a2747016b3e13de58c7d4115a3d5c97935 # v3.0.1
with:
id: ${{ inputs.metrics-id || inputs.metrics-job-name }}
basic-auth: ${{ inputs.gc-basic-auth }}
hostname: ${{ inputs.gc-host }}
org-id: ${{ inputs.gc-org-id}}
this-job-name: ${{ inputs.metrics-job-name }}
continue-on-error: true
Loading

0 comments on commit dca9ab8

Please sign in to comment.