Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prDraft input to changeset signed-commits action #269

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

momentmaker
Copy link
Contributor

@momentmaker momentmaker commented Apr 4, 2024

This adds a new input to signed-commits action:

  prDraft:
    description:
      A boolean value to indicate whether the pull request should be a draft or
      not. Default to `false`
    required: false
    default: "false"

@momentmaker momentmaker requested a review from a team as a code owner April 4, 2024 20:04
Copy link
Contributor

@erikburt erikburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be creating other unit tests for runVersion(...) where draft is true, and labels are populated?

@momentmaker
Copy link
Contributor Author

Should we be creating other unit tests for runVersion(...) where draft is true, and labels are populated?

hmm the draft pr test is easy to do but add a label requires create a new graphql query and response...

@momentmaker
Copy link
Contributor Author

Should we be creating other unit tests for runVersion(...) where draft is true, and labels are populated?

hmm the draft pr test is easy to do but add a label requires create a new graphql query and response...

wait nvm. I got it lol

@@ -34,6 +34,40 @@ exports[`version creates simple PR 1`] = `
]
`;

exports[`version creates simple PR in draft mode with do-not-merge label 1`] = `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this validating that the label was added to the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question - are we also not just making the

  pulls: {
    create: jest.fn(),
  },

and just expect it's there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I'm going to remove labels as we don't need it. I think adding it to the title is perfectly fine:
smartcontractkit/chainlink#12722

@momentmaker momentmaker changed the title add prDraft and labels input to changeset signed-commits action add prDraft input to changeset signed-commits action Apr 5, 2024
actions/signed-commits/src/run.test.ts Outdated Show resolved Hide resolved
actions/signed-commits/src/__snapshots__/run.test.ts.snap Outdated Show resolved Hide resolved
@momentmaker momentmaker merged commit 7748941 into main Apr 5, 2024
7 checks passed
@momentmaker momentmaker deleted the re-2428/changeset-signed-commits-action branch April 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants