-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prDraft input to changeset signed-commits action #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be creating other unit tests for runVersion(...)
where draft
is true, and labels
are populated?
hmm the draft pr test is easy to do but add a label requires create a new graphql query and response... |
wait nvm. I got it lol |
@@ -34,6 +34,40 @@ exports[`version creates simple PR 1`] = ` | |||
] | |||
`; | |||
|
|||
exports[`version creates simple PR in draft mode with do-not-merge label 1`] = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this validating that the label was added to the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question - are we also not just making the
pulls: {
create: jest.fn(),
},
and just expect it's there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I'm going to remove labels
as we don't need it. I think adding it to the title is perfectly fine:
smartcontractkit/chainlink#12722
This adds a new input to
signed-commits
action: