Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manifest action #53

Merged
merged 8 commits into from
Nov 28, 2023
Merged

add manifest action #53

merged 8 commits into from
Nov 28, 2023

Conversation

tt-cll
Copy link
Collaborator

@tt-cll tt-cll commented Nov 27, 2023

(opening from a fork because I don't have write access to this repo)

Our team needs a workflow that will automatically build all nix packages in a given repo. We want to publish this as a re-usable action so we can share it across repos. https://smartcontract-it.atlassian.net/browse/INT2-413

@tt-cll tt-cll requested a review from a team as a code owner November 27, 2023 18:17
@momentmaker
Copy link
Contributor

nice! could you please add a changeset to this new action?

@tt-cll
Copy link
Collaborator Author

tt-cll commented Nov 27, 2023

nice! could you please add a changeset to this new action?

sure! Are there instructions on how to do that? Sorry, I've never used that tool before

@momentmaker
Copy link
Contributor

yeah you can do pnpm i first and then pnpm changeset at the root and check the action you just added :)

Comment on lines 26 to 29
cache-token:
description: "Cachix auth token for private cache"
required: false
default: ""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an S3 option as well or is it too early?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off and add that once we can test it e2e

@momentmaker momentmaker merged commit 988c92e into smartcontractkit:main Nov 28, 2023
4 checks passed
@tt-cll tt-cll deleted the tt/manifestBuild branch November 28, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants