llm-pr-writer 0.4.0 : switch to github-script for posting github comment for flexibility #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalanyuz
force-pushed
the
feat/llm-aer-040
branch
from
26a4bc3
to
3eb3dd7
Compare
|
cc: @chainchad |
Tofel
reviewed
Oct 23, 2024
| @@ -160,10 +161,11 @@ runs: | |||
| $(cat chatgpt_output.txt) | |||
| </$WORKFLOW_ID>" | |||
|
|
|||
| # post the error report to the PR | |||
| # prepare the report message | |||
| ${{ github.action_path }}/update_pr_comment.sh | |||
There was a problem hiding this comment.
that's a nice one, didn't know about ${{ github.action_path }}
Tofel
reviewed
Oct 23, 2024
| @@ -9,21 +9,22 @@ set -euo pipefail | |||
| # - SKIP_ON_SUCCESS | |||
|
|
|||
| # Fetch the comments on the pull request and filter for comments by github.actor | |||
| author_comments=$(gh pr view "$PR_NUMBER" --json comments --jq '.comments | map(select(.author.login == "github-actions" and (.body | contains("## AER Report:"))))') | |||
| author_comments=$(gh pr view "$PR_NUMBER" --json comments --jq '( | |||
There was a problem hiding this comment.
maybe this should be renamed to last_author_comment?
kalanyuz
force-pushed
the
feat/llm-aer-040
branch
from
3eb3dd7
to
fe2f15b
Compare
Tofel
approved these changes
Oct 23, 2024
chainchad
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the patch in 0.3.1, 0.4.0 switches over to github-action scripts to update specific comment_id instead of deciding to update the last message if it's made by the script, which has low spam reduction effect in bot-busy environments.
To test the effectiveness of the script, here are 4 test cases: