Update Action for GAP v2 #688
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchad
commented
Nov 1, 2024
There was a problem hiding this comment.
Need to determine which CA this is. We'll need to make sure we have CA's added which will let us trust all upstream endpoints, especially for K8s.
chainchad
commented
Nov 1, 2024
|
|
||
| - name: Argocd login | ||
| if: inputs.use-argocd == 'true' | ||
| - name: Test kubectl |
There was a problem hiding this comment.
Should probably completely remove this step.
chainchad
commented
Nov 1, 2024
| --log-failed-requests $DUPLICATE_AUTH_HEADER_FLAG | ||
| # Copy AWS CA certs | ||
| cp ${{ github.action_path }}/aws-ca.crt "${PATH_CERTS_DIR}" | ||
| chmod 644 "${PATH_CERTS_DIR}/server.key" |
There was a problem hiding this comment.
Do we need to set this to 644?
chainchad
commented
Nov 1, 2024
| - name: Get GH JWT Token | ||
| if: inputs.use-k8s == 'true' | ||
| id: get-jwt-token | ||
| uses: actions/github-script@v7.0.1 |
There was a problem hiding this comment.
Suggested change
| uses: actions/github-script@v7.0.1 | |
| uses: actions/github-script@v7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.