Add DA cost estimation to CCIPMessageExecCostUSD18Calculator #275
Conversation
rstout
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
rstout
force-pushed
the
rs/exec-da-cost
branch
from
ad24a2b
to
e7913cf
Compare
| } | ||
|
|
||
| // calculateMessageMaxDAGas calculates the total DA gas needed for a CCIP message | ||
| func calculateMessageMaxDAGas( |
There was a problem hiding this comment.
DA is quite specific to EVM, I'm not expert of v2 code base, wondering if you want to put it under an EVM folder somewhere?
There was a problem hiding this comment.
You right. We will work on making this logic chain abstracted in a second step
There was a problem hiding this comment.
The priority is to unblock the itests right now, so our plan is to merge this, then move this logic to chainlink with the other EVM specific logic
| } | ||
|
|
||
| messageGas := calculateMessageMaxDAGas(message, daConfig) | ||
| return big.NewInt(0).Mul(messageGas, dataAvailabilityFee) |
There was a problem hiding this comment.
is this actually returning fee in USD or fee in the native currency?
there is a pre-existing comment that says executionFee (USD18/gas) so I presume dataAvailabilityFee is denoted in USD/gas as opposed to native/gas, but after reading the code, it seems feeComponents is read straight from the ChainWriter, does chain writer return native/gas (which I thought should be the case and will make this impl incorrect). or actually usd/gas, please double check
There was a problem hiding this comment.
The value is read from https://github.com/smartcontractkit/chainlink/blob/develop/contracts/src/v0.8/ccip/FeeQuoter.sol#L303
which is denominated in USD.
There was a problem hiding this comment.
Looks like USD/gas: https://github.com/smartcontractkit/chainlink/blob/a1e4f8e960d4b5bf05e353dec3254d13c9a3b4c8/contracts/src/v0.8/ccip/FeeQuoter.sol#L303
function getDestinationChainGasPrice(
uint64 destChainSelector
) external view returns (Internal.TimestampedPackedUint224 memory) {
return s_usdPerUnitGasByDestChainSelector[destChainSelector];
}
There was a problem hiding this comment.
I'm still confused, isn't the value fetched from ChainWriter, maybe I missed it, where is it read from FeeQuoter?
0xnogo
force-pushed
the
rs/exec-da-cost
branch
from
3603c72
to
5a53390
Compare
|
No description provided.