RMN - minor code improvements #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
commented
Nov 1, 2024
| rmnNodes, err := c.rmnHomeReader.GetRMNNodesInfo(rmnRemoteCfg.ConfigDigest) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("get rmn nodes info: %w", err) | ||
| } | ||
|
|
||
| c.lggr.Infow("got RMN nodes info", "nodes", rmnNodes) |
There was a problem hiding this comment.
Refactoring of the logic that processes lane update requests. Extracted and unit tested a standalone function.
dimkouv
commented
Nov 1, 2024
| @@ -160,10 +160,7 @@ func (r *peerClient) getOrCreateRageP2PStream(rmnNode rmntypes.HomeNodeInfo) (St | |||
| } | |||
|
|
|||
| rmnPeerID := rmnNode.PeerID.String() | |||
|
|
|||
There was a problem hiding this comment.
Each rmn node has a field called StreamNamePrefix. Supports different RMN nodes that are running different RMN offchain version. v1_6 is still hardcoded in initialization until the change is integrated in RMNHome.
dimkouv
commented
Nov 1, 2024
| @@ -1,19 +1,5 @@ | |||
| package slicelib | |||
|
|
|||
| // GroupBy groups a slice based on a specific item property. The returned groups slice is deterministic. | |||
| func GroupBy[T any, K comparable](items []T, prop func(T) K) ([]K, map[K][]T) { | |||
There was a problem hiding this comment.
Remove unused function.
dimkouv
requested review from
winder,
rstout,
asoliman92,
makramkd,
mateusz-sekara and
0xnogo
dimkouv
changed the title
dimkouv
changed the title
dimkouv
changed the title
makramkd
approved these changes
Nov 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comments about the changes. https://github.com/smartcontractkit/chainlink-ccip/pull/289/files