-
Notifications
You must be signed in to change notification settings - Fork 24
Update chainlink-protos/cre/go version #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 nadahalli, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
…mon into confhttp3
const file_capabilities_internal_basictrigger_v1_basic_trigger_proto_rawDesc = "" + | ||
"\n" + | ||
"9capabilities/internal/basictrigger/v1/basic_trigger.proto\x12%capabilities.internal.basictrigger.v1\x1a)tools/generator/v1beta/cre_metadata.proto\"4\n" + | ||
"9capabilities/internal/basictrigger/v1/basic_trigger.proto\x12%capabilities.internal.basictrigger.v1\x1a*tools/generator/v1alpha/cre_metadata.proto\"4\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't beta -> alpha a downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it. But apparently, the beta upgrade was rolled back? I am really not sure about this. @MStreet3 should know the facts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this PR depends on a commit that is not a part of main yet. Waiting for smartcontractkit/chainlink-protos#218 to get merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smartcontractkit/chainlink-protos#218 got merged, and I have used the updated version here. This is good for review now.
Please take another look. |
Requires
Supports