Skip to content

Conversation

nadahalli
Copy link
Contributor

Requires

Supports

Copy link

👋 nadahalli, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link

github-actions bot commented Oct 16, 2025

✅ API Diff Results - No breaking changes


📄 View full apidiff report

pavel-raykov
pavel-raykov previously approved these changes Oct 16, 2025
const file_capabilities_internal_basictrigger_v1_basic_trigger_proto_rawDesc = "" +
"\n" +
"9capabilities/internal/basictrigger/v1/basic_trigger.proto\x12%capabilities.internal.basictrigger.v1\x1a)tools/generator/v1beta/cre_metadata.proto\"4\n" +
"9capabilities/internal/basictrigger/v1/basic_trigger.proto\x12%capabilities.internal.basictrigger.v1\x1a*tools/generator/v1alpha/cre_metadata.proto\"4\n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't beta -> alpha a downgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it. But apparently, the beta upgrade was rolled back? I am really not sure about this. @MStreet3 should know the facts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this PR depends on a commit that is not a part of main yet. Waiting for smartcontractkit/chainlink-protos#218 to get merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smartcontractkit/chainlink-protos#218 got merged, and I have used the updated version here. This is good for review now.

@nadahalli nadahalli requested review from MStreet3 and nolag October 20, 2025 11:34
@nadahalli nadahalli marked this pull request as draft October 20, 2025 11:40
@nadahalli nadahalli marked this pull request as ready for review October 21, 2025 09:39
@nadahalli
Copy link
Contributor Author

Please take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants