-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCI-1511: only contract schema changes #359
BCI-1511: only contract schema changes #359
Conversation
@@ -22,6 +22,7 @@ backtraces = ["cosmwasm-std/backtraces"] | |||
library = [] | |||
|
|||
[dependencies] | |||
cosmwasm-schema = { version = "1.1.5" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why the need for this? The crate's readme specifically states it's a dev dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://book.cosmwasm.com/basics/good-practices.html#json-schema -- just copied over here. It also didn't work as a dev dependency as I wasn't able to use it in schema.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it does look like the schema conventions changed slightly (so no more dev dependency, custom macros)
Originally diffed from #355 to just seperate out the schema changes
Changes:
{ "owner": {} }
instead of"owner"
to query the owner of a contract) for best practices + type generation compatibilityTODO: make changes to gauntlet to support the query message types (in a later PR)