integration-tests: convert cosmos pub keys to prefixed addresses #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfal
changed the title
cfal
force-pushed
the
cosmos-keystore
branch
3 times, most recently
from
fd629af
to
847d1e9
Compare
… options to config
cfal
force-pushed
the
cosmos-keystore
branch
from
847d1e9
to
1a9d9b2
Compare
calvwang9
reviewed
Sep 7, 2023
| ) | ||
|
|
||
| // Creates a bech32 address from a hex-encoded secp256k1 public key. | ||
| func CreateBech32Address(pubKey, accountPrefix string) (string, error) { |
There was a problem hiding this comment.
not a big deal but iirc, this function/logic is duplicated in the keystore in core right? is it worth consolidating into one function across both repos?
There was a problem hiding this comment.
definitely - i'm planning on removing the keystore code and get it to use this function.
calvwang9
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCI-1740