BCI-1224.rewrite example contracts #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck_enabled to match previous contract
…rewrite-example-contracts
archseer
force-pushed
the
augustus.BCI-1224.rewrite-example-contracts
branch
from
3319c2a
to
b9150b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors both example folders.
Because all our cairo contracts are compiled on cairo-rc-0, they are not deployable to starknet goerli alpha. Therefore, the aggregator consumer examples are only tested on devnet.
I had to rework the functionality of the examples/ for the price consumer with sequencer check because it didn't make sense in the last revision. So for now, I eliminated the tests since they were testing defunct logic. (i.e. it takes longer than 60 seconds to deploy the contracts so the reports will always be stale)