Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functions] Add provider method stub in relayer #312

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Aug 1, 2023

No description provided.

@bolekk bolekk requested a review from jmank88 August 1, 2023 21:23
@bolekk bolekk temporarily deployed to integration August 1, 2023 21:23 — with GitHub Actions Inactive
@bolekk bolekk temporarily deployed to integration August 1, 2023 21:23 — with GitHub Actions Inactive
@bolekk bolekk requested a review from aalu1418 August 2, 2023 04:19
jmank88
jmank88 previously approved these changes Aug 2, 2023
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you still need a make format-go-mod-tidy to update the dependencies in the various test files

@bolekk bolekk temporarily deployed to integration August 2, 2023 14:17 — with GitHub Actions Inactive
@bolekk bolekk temporarily deployed to integration August 2, 2023 14:17 — with GitHub Actions Inactive
@bolekk bolekk temporarily deployed to integration August 2, 2023 14:17 — with GitHub Actions Inactive
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since test failures seem pre-existing (smoke tests) or completely unrelated (gauntlet tests), and the codebase is still being worked on pretty heavily

@bolekk bolekk merged commit d2c9567 into develop Aug 2, 2023
13 of 16 checks passed
@bolekk bolekk deleted the feature/functions-relay branch August 2, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants