Starknet Chain Client: Add Block Methods

[augustbleeds]

https://smartcontract-it.atlassian.net/browse/BCI-2676

Adding 3 block-related methods so RTSP can begin playing around with fetching blocks and the Batch() method to lay the groundwork for the rest of the methods. Rest of the process should be straightforward after this PR.

Added the ChainId method as well. Turns out the starknet.go provider automatically caches the chainId after first request, so our implementation uses the batchCall always

Original Design Doc: https://docs.google.com/document/d/10jsfp7_VqDv2GFGILmTX2ey-p_yaFyvxPaVszL6kg6g/edit

Open Questions:

• For batch calls, the user will need to iterate through the batchElem array and cast the Result interface to the expected return type. This seems like a weird user experience so I'm open to feedback on how to improve this. RESOLVED

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[augustbleeds]

i learned the result is stored within the same BatchElem type.

and that you need to allocate the memory for the type you expect to be returned, which is json deserialized from the RPC

[augustbleeds]

will be uncommented as the corresponding methods in the chain client are implemented

[augustbleeds]

add the ethrpc client to the struct so we can take advantage of its batch call capabilities!

[archseer]

How different is this from using what we have in client.go/Reader? We should be able to share the interfaces

[augustbleeds]

there's definitely some possibility for re-using the reader client methods. but if you mean to combine the interfaces, we've made it a design decision that chain client interface is distinct and set apart because it is dictated by the customer (atlas now) needs.

[augustbleeds]

For this PR specifically, we introduced BlockByHash and BlockHashAndNumber.

In terms of replacing, re-using the existing calls, I didn't remove/replace BlockByHash (returns txs) with the already written BlockWithTxHashes (returns tx hashes) because we need the block with txs.

I can simplify the logic of LatestBlockHeight to call BlockHashAndNumber, though. Would you like me to do that?

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
87.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube