Add Gauntlet++ Op Client and Op Requests into E2E Integration Tests #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
had a problem deploying
to
integration
GitHub Actions
Failure
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
had a problem deploying
to
integration
GitHub Actions
Failure
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
had a problem deploying
to
integration
GitHub Actions
Failure
This reverts commit 358cf94.
chray-zhang
had a problem deploying
to
integration
GitHub Actions
Failure
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
had a problem deploying
to
integration
GitHub Actions
Failure
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
|
|
||
| type StarknetGauntletPlusPlus struct { | ||
| client *g.ClientWithResponses | ||
| gr *http.Response |
There was a problem hiding this comment.
what's gr stand for and where is it used? is it the acronym for "gauntlet response"?
There was a problem hiding this comment.
Yup. Do you think I should expand it to response?
| return nil | ||
| } | ||
|
|
||
| func (sgpp *StarknetGauntletPlusPlus) executeRequestReturnsReport(command string, inputMap map[string]interface{}) (g.Report, error) { |
There was a problem hiding this comment.
if you change the parameter to just Request this function can be called executeWithReport
chray-zhang
temporarily deployed
to
integration
GitHub Actions
Inactive
chray-zhang
had a problem deploying
to
integration
GitHub Actions
Failure
|
|
looks good! now we're just waiting for the github token to pull in the private go modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ops are not yet integrated into E2E Test workflow. That will be captured in this ticket: https://smartcontract-it.atlassian.net/jira/software/c/projects/NONEVM/boards/357/backlog?selectedIssue=NONEVM-291
Why:
https://smartcontract-it.atlassian.net/browse/NONEVM-330