add CRE workflow http trigger changeset#21446
Open
karen-stepanyan wants to merge 3 commits intodevelopfrom
Open
add CRE workflow http trigger changeset#21446karen-stepanyan wants to merge 3 commits intodevelopfrom
karen-stepanyan wants to merge 3 commits intodevelopfrom
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM (new changeset that interacts with CRE gateway auth + request signing; incorrect request shape/signature will cause production trigger failures)
This PR adds a new Data Feeds changeset intended to trigger a CRE workflow execution through an HTTP/JSON-RPC gateway call, including a signed ETH-JWT for authentication.
Changes:
- Add
TriggerCREWorkflowConfig/TriggerCREWorkflowInputtypes for configuring workflow triggers. - Introduce a new
TriggerWorkflowChangesetthat builds a JSON-RPCworkflows.executerequest and signs/authenticates it via an ETH-JWT.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| deployment/data-feeds/changeset/types/types.go | Adds config/input types used by the new workflow trigger changeset. |
| deployment/data-feeds/changeset/trigger_workflow.go | Implements the new changeset that signs a request and POSTs it to the gateway. |
Scrupulous human review needed on:
trigger_workflow.gorequest format/auth placement (JSON-RPC structure and where the JWT is carried).createSignedJWTcorrectness vs gateway-side verification expectations (digest computation, signature encoding, claims).
Recommended reviewers (per CODEOWNERS):
@smartcontractkit/data-feeds-engineers,@smartcontractkit/operations-platform,@smartcontractkit/core(owners for/deployment/data-feedsand/deployment)- Additionally consider looping in
@smartcontractkit/keystonedue to CRE/workflow gateway auth/protocol coupling.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/DF-23549