Skip to content

enhance aptos mcms proposal generation#21450

Open
FelixFan1992 wants to merge 6 commits intodevelopfrom
improve-aptos-mcms-support
Open

enhance aptos mcms proposal generation#21450
FelixFan1992 wants to merge 6 commits intodevelopfrom
improve-aptos-mcms-support

Conversation

@FelixFan1992
Copy link
Contributor

Requires

Supports

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
/deployment/ccip 4 @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/operations-platform, @smartcontractkit/core
/deployment/common 1 @smartcontractkit/operations-platform
go.mod 5 @smartcontractkit/core, @smartcontractkit/foundations
go.sum 5 @smartcontractkit/core, @smartcontractkit/foundations
integration-tests/go.mod 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations
integration-tests/go.sum 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link

trunk-io bot commented Mar 6, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: HIGH — touches deployment proposal generation logic for Aptos MCMS (including CurseMCMS metadata semantics) and performs broad dependency upgrades across multiple Go modules.

This PR enhances Aptos CurseMCMS proposal generation so the proposal metadata and inspector behavior correctly target the curse_mcms module/binding, while also updating MCMS/deployment-related dependencies across deployment, integration, and system-test modules.

Changes:

  • Update Aptos CurseMCMS proposal generation to use NewInspectorWithMCMSType(..., MCMSTypeCurse) and persist MCMSTypeCurse into Aptos chain metadata AdditionalFields.
  • Add clarification in shared MCMS helper about Aptos inspectors being constructed directly by Aptos changesets for finer control.
  • Bump MCMS + related dependencies (deployments framework, protos, grpc, aws sdk, etc.) across several sub-modules.

Reviewed changes

Copilot reviewed 9 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
system-tests/tests/go.mod Dependency upgrades for system test module (incl. mcms + related libs).
system-tests/lib/go.mod Dependency upgrades for system-tests lib module.
system-tests/lib/go.sum Checksums updated to match system-tests lib dependency changes.
integration-tests/load/go.mod Dependency upgrades for integration load-test module.
integration-tests/go.mod Dependency upgrades for integration-tests module.
deployment/go.mod Deployment tooling dependency upgrades (incl. mcms v0.36.4).
deployment/common/proposalutils/mcms_helpers.go Adds note clarifying Aptos changesets build inspectors directly.
deployment/ccip/changeset/aptos/utils/mcms.go Switch CurseMCMS inspector approach + set Aptos chain metadata MCMSTypeCurse.
deployment/ccip/changeset/aptos/cs_deploy_curse_mcms.go Updates comment to match new CurseMCMS inspector approach.
core/scripts/go.mod Dependency upgrades for core scripts module.
core/scripts/go.sum Checksums updated to match core scripts dependency changes.

Comment on lines +48 to 52
github.com/smartcontractkit/chainlink-deployments-framework v0.86.0
github.com/smartcontractkit/chainlink-evm v0.3.4-0.20260303141232-9cc3feb83863
github.com/smartcontractkit/chainlink-evm/contracts/cre/gobindings v0.0.0-20260107191744-4b93f62cffe3
github.com/smartcontractkit/chainlink-evm/gethwrappers v0.0.0-20251222115927-36a18321243c
github.com/smartcontractkit/chainlink-framework/multinode v0.0.0-20251021173435-e86785845942
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR’s goal (Aptos MCMS proposal generation) is clear, but this module update also bumps a large set of dependencies beyond the Aptos/MCMS stack (e.g., deployments framework, multiple proto/libs, etc.). To keep review/rollback safer, consider calling out the broad dependency upgrade explicitly in the PR description (or splitting the dependency refresh into a separate PR if it isn’t required for LINK-777).

Copilot uses AI. Check for mistakes.
@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants