enhance aptos mcms proposal generation#21450
Conversation
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
✅ No conflicts with other open PRs targeting |
|
I see you updated files related to
|
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH — touches deployment proposal generation logic for Aptos MCMS (including CurseMCMS metadata semantics) and performs broad dependency upgrades across multiple Go modules.
This PR enhances Aptos CurseMCMS proposal generation so the proposal metadata and inspector behavior correctly target the curse_mcms module/binding, while also updating MCMS/deployment-related dependencies across deployment, integration, and system-test modules.
Changes:
- Update Aptos CurseMCMS proposal generation to use
NewInspectorWithMCMSType(..., MCMSTypeCurse)and persistMCMSTypeCurseinto Aptos chain metadataAdditionalFields. - Add clarification in shared MCMS helper about Aptos inspectors being constructed directly by Aptos changesets for finer control.
- Bump MCMS + related dependencies (deployments framework, protos, grpc, aws sdk, etc.) across several sub-modules.
Reviewed changes
Copilot reviewed 9 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/go.mod | Dependency upgrades for system test module (incl. mcms + related libs). |
| system-tests/lib/go.mod | Dependency upgrades for system-tests lib module. |
| system-tests/lib/go.sum | Checksums updated to match system-tests lib dependency changes. |
| integration-tests/load/go.mod | Dependency upgrades for integration load-test module. |
| integration-tests/go.mod | Dependency upgrades for integration-tests module. |
| deployment/go.mod | Deployment tooling dependency upgrades (incl. mcms v0.36.4). |
| deployment/common/proposalutils/mcms_helpers.go | Adds note clarifying Aptos changesets build inspectors directly. |
| deployment/ccip/changeset/aptos/utils/mcms.go | Switch CurseMCMS inspector approach + set Aptos chain metadata MCMSTypeCurse. |
| deployment/ccip/changeset/aptos/cs_deploy_curse_mcms.go | Updates comment to match new CurseMCMS inspector approach. |
| core/scripts/go.mod | Dependency upgrades for core scripts module. |
| core/scripts/go.sum | Checksums updated to match core scripts dependency changes. |
| github.com/smartcontractkit/chainlink-deployments-framework v0.86.0 | ||
| github.com/smartcontractkit/chainlink-evm v0.3.4-0.20260303141232-9cc3feb83863 | ||
| github.com/smartcontractkit/chainlink-evm/contracts/cre/gobindings v0.0.0-20260107191744-4b93f62cffe3 | ||
| github.com/smartcontractkit/chainlink-evm/gethwrappers v0.0.0-20251222115927-36a18321243c | ||
| github.com/smartcontractkit/chainlink-framework/multinode v0.0.0-20251021173435-e86785845942 |
There was a problem hiding this comment.
This PR’s goal (Aptos MCMS proposal generation) is clear, but this module update also bumps a large set of dependencies beyond the Aptos/MCMS stack (e.g., deployments framework, multiple proto/libs, etc.). To keep review/rollback safer, consider calling out the broad dependency upgrade explicitly in the PR description (or splitting the dependency refresh into a separate PR if it isn’t required for LINK-777).
|




Requires
Supports