Skip to content

Comment doesn't apply. This is the cleanest way #21456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickhuie19 wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −3
Open

Comment doesn't apply. This is the cleanest way #21456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions core/services/gateway/network/httpserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,6 @@ func (s *httpServer) isAllowedOrigin(origin string) bool {
return false
}
for _, allowed := range s.config.CORSAllowedOrigins {
// probably better to do this once when server starts and store it in a map
// this is an easier solution so we don't have to apply more changes to the code
// just need to be careful when specifying allowed origins in the config file
allowedScheme, allowedHost, allowedPort, err := s.splitURL(allowed)
if err != nil {
s.lggr.Debug("error parsing allowed origin URL", err)
Expand Down
Loading