OPDATA-4597: Remove quadratic loop over addresses in por-indexer

[dskloetc]

OPDATA-4597

Description

por-indexer iterates over all addresses and address them to a list like this [...existingAddresses, address].
This is O(n^2).

Changes

Changed the code to use push instead of [..., ].

Steps to Test

1. Added some timing code and noticed that for 25,000 addresses the time went from >500ms to <10ms for just this loop, on my Mac.
2. Tested with the params of all 33 feeds in RDD that use por-indexer.
3. Existing test pass.

Quality Assurance

• If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
• If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file.
• If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
• The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
• This is related to a maximum of one Jira story or GitHub issue.
• Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
• All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

[changeset-bot]

🦋 Changeset detected

Latest commit: 94bdfbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@chainlink/por-indexer-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR