Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevX Improvements. #70

Merged
merged 3 commits into from
Jun 21, 2024
Merged

DevX Improvements. #70

merged 3 commits into from
Jun 21, 2024

Conversation

zeuslawyer
Copy link
Contributor

@zeuslawyer zeuslawyer commented Jun 20, 2024

  1. add helpful error if any env var not set.
  2. remove https scheme when the BASE_URL env var includes it so it does not error on request.

Below is a summarization created by an LLM (gpt-4-turbo-2024-04-09). Be mindful of hallucinations and verify accuracy.

Why

Enhanced error handling and configuration validation in client.go for better stability and user feedback. Updated dependencies in go.mod for improved functionality and security.

What

client.go

  • Added checks for empty environment variables: BASE_URL, CLIENT_ID, CLIENT_SECRET
  • Added removal of "https://" prefix from baseUrl

go.mod

  • Added multiple indirect dependencies such as github.com/beorn7/perks, github.com/btcsuite/btcd, etc.

1. add helpful error if any env var not set.
2. remove https scheme when the BASE_URL env var includes it so it does not error on request.
@zeuslawyer zeuslawyer requested a review from khadni June 20, 2024 05:57
@khadni khadni merged commit 98ac247 into main Jun 21, 2024
@khadni khadni deleted the zp/patch-streams-direct branch June 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants