Skip to content

chore: fix clippy #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morenol merged 2 commits into from
Feb 25, 2024
Merged

chore: fix clippy #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e39859
chore: fix clippy
morenol Feb 25, 2024
a071d75
Merge branch 'development' into fix-clippy-176
morenol Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/linalg/basic/matrix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,11 @@ impl<T: Debug + Display + Copy + Sized> DenseMatrix<T> {

/// New instance of `DenseMatrix` from 2d array.
pub fn from_2d_array(values: &[&[T]]) -> Self {
DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect())
DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect::<Vec<_>>())
}

/// New instance of `DenseMatrix` from 2d vector.
pub fn from_2d_vec(values: &Vec<Vec<T>>) -> Self {
pub fn from_2d_vec(values: &[Vec<T>]) -> Self {
let nrows = values.len();
let ncols = values
.first()
Expand Down
10 changes: 5 additions & 5 deletions src/preprocessing/numerical.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,11 @@ mod tests {
fn combine_three_columns() {
assert_eq!(
build_matrix_from_columns(vec![
DenseMatrix::from_2d_vec(&vec![vec![1.0], vec![1.0], vec![1.0],]),
DenseMatrix::from_2d_vec(&vec![vec![2.0], vec![2.0], vec![2.0],]),
DenseMatrix::from_2d_vec(&vec![vec![3.0], vec![3.0], vec![3.0],])
DenseMatrix::from_2d_vec(&[vec![1.0], vec![1.0], vec![1.0]]),
DenseMatrix::from_2d_vec(&[vec![2.0], vec![2.0], vec![2.0]]),
DenseMatrix::from_2d_vec(&[vec![3.0], vec![3.0], vec![3.0]])
]),
Some(DenseMatrix::from_2d_vec(&vec![
Some(DenseMatrix::from_2d_vec(&[
vec![1.0, 2.0, 3.0],
vec![1.0, 2.0, 3.0],
vec![1.0, 2.0, 3.0]
Expand Down Expand Up @@ -365,7 +365,7 @@ mod tests {
);

assert!(
&DenseMatrix::<f64>::from_2d_vec(&vec![fitted_scaler.stds]).approximate_eq(
&DenseMatrix::<f64>::from_2d_vec(&[fitted_scaler.stds]).approximate_eq(
&DenseMatrix::from_2d_array(&[&[
0.29426447500954,
0.16758497615485,
Expand Down