Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement predict_proba for DecisionTreeClassifier #287

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Implement predict_proba for DecisionTreeClassifier #287

merged 5 commits into from
Jan 20, 2025

Conversation

Mec-iS
Copy link
Collaborator

@Mec-iS Mec-iS commented Jan 20, 2025 •
edited
Loading

start implementing for issue #50

Fixes #50

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

missing predict_proba for DecisionTreeClassifier

New expected behaviour

Implement it

Next one for Random Forest

@Mec-iS Mec-iS requested a review from morenol January 20, 2025 15:01
morenol
morenol previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mec-iS Mec-iS requested a review from morenol January 20, 2025 16:09
@Mec-iS Mec-iS merged commit 3da433f into development Jan 20, 2025
12 checks passed
@Mec-iS Mec-iS deleted the issue-50-predict-proba-for-decisiontree branch January 20, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morenol morenol morenol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a new method that predicts probabilities, where it makes sense
2 participants
@Mec-iS @morenol