Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring SdlRouterService and SdlBroadcastReceiver #1352

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

RHenigan
Copy link
Contributor

Fixes #349

This PR is [not ready] for review.

Risk

This PR makes [minor] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Summary

This branch will deprecate SDLRouterService and SDLBroadcastReceiver and create BaseRouterService and BaseBroadcastReceiver which extend these deprecated classes. This is because there is a lot of confusion added by the creating a SDLRouterService class in the application which uses the same name as its parent class.

CLA

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #1352 into develop will decrease coverage by 0.00%.
The diff coverage is 9.80%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1352      +/-   ##
=============================================
- Coverage      47.67%   47.67%   -0.01%     
- Complexity      4432     4433       +1     
=============================================
  Files            489      491       +2     
  Lines          23848    23851       +3     
  Branches        2753     2753              
=============================================
+ Hits           11369    11370       +1     
- Misses         11778    11780       +2     
  Partials         701      701              
Impacted Files Coverage Δ Complexity Δ
...artdevicelink/transport/BaseBroadcastReceiver.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rtdevicelink/transport/MultiplexBaseTransport.java 39.13% <0.00%> (ø) 3.00 <0.00> (ø)
...artdevicelink/transport/MultiplexTcpTransport.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...artdevicelink/transport/MultiplexUsbTransport.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rtdevicelink/transport/RouterServiceValidator.java 52.60% <0.00%> (ø) 49.00 <0.00> (ø)
...martdevicelink/transport/SdlBroadcastReceiver.java 3.41% <0.00%> (-0.02%) 2.00 <0.00> (ø)
...om/smartdevicelink/transport/SdlRouterService.java 11.64% <ø> (ø) 20.00 <0.00> (ø)
...tdevicelink/transport/SdlRouterStatusProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...smartdevicelink/transport/TCPTransportManager.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...com/smartdevicelink/transport/TransportBroker.java 20.15% <0.00%> (ø) 17.00 <0.00> (ø)
... and 7 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant