[Issue #34] Fix for array urlencoding (XCode 15.0.1, iOS 17.0) (#35)

* Tests fixed

* URLEncode - remove semicolon from allowed characters

* Internal bata version

* Separator extracted as static variable

* Version file restored

---------

Co-authored-by: Marek Matulski <mmatulski-c@hippo.com>

Sources/SmartyStreets/SmartyRequest.swift

@@ -54,7 +54,9 @@ public class SmartyRequest {
     }
 
     func urlEncode(value: String) -> String {
-        return value.addingPercentEncoding(withAllowedCharacters: .urlPathAllowed)!
+        var allowedCharacters = CharacterSet.urlPathAllowed
+        allowedCharacters.remove(charactersIn: USAutocompleteProClient.arrayItemsSeparator)
+        return value.addingPercentEncoding(withAllowedCharacters: allowedCharacters)!
     }
 
     func setPayload(payload:Data) {

Sources/SmartyStreets/USAutocompletePro/USAutocompleteProClient.swift

@@ -2,7 +2,9 @@ import Foundation
 
 public class USAutocompleteProClient: NSObject {
     //    It is recommended to instantiate this class using SSClientBuilder
-
+
+    static let arrayItemsSeparator = ";"
+
     var sender:SmartySender
     public var serializer:SmartySerializer
 
@@ -65,6 +67,6 @@ public class USAutocompleteProClient: NSObject {
             return String()
         }
 
-        return list.joined(separator: ";")
+        return list.joined(separator: Self.arrayItemsSeparator)
     }
 }

Tests/SmartyStreetsTests/SmartyRequestTests.swift

@@ -44,4 +44,10 @@ class SmartyRequestTests: XCTestCase {
         XCTAssertEqual(url, "https://fakesearch.com/lookup?street=Parks%20Blvd")
     }
 
+    func testGetURLWithURLEncodedArray() {
+        smartyRequest.urlPrefix = "https://fakesearch.com/lookup?"
+        smartyRequest.setValue(value: "abc;def", HTTPParameterField: "array")
+        let url = smartyRequest.getUrl()
+        XCTAssertEqual(url, "https://fakesearch.com/lookup?array=abc%3Bdef")
+    }
 }