-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/LS25000142/Fix concurrence between DS and File #696
Merged
lanarimarco
merged 44 commits into
develop
from
bugfix/LS25000142/fix-concurrence-between-ds-and-file
Jan 27, 2025
Merged
Bugfix/LS25000142/Fix concurrence between DS and File #696
lanarimarco
merged 44 commits into
develop
from
bugfix/LS25000142/fix-concurrence-between-ds-and-file
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout specify the DS. There are two DS with same fields.
…nitions` if is declared a DS which uses `EXTNAME` to the same file
…declared as not `QUALIFIED`
In draft for a wrong behavior discovered by @dom-apuliasoft |
lanarimarco
requested changes
Jan 23, 2025
rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/SymbolTable.kt
Show resolved
Hide resolved
Yes, but since you are no longer searching just by name, I will ask you
to perform some performance tests with a very large loop to assess the cost
of this feature in terms of performance.
Il giorno ven 24 gen 2025 alle ore 07:54 Davide ***@***.***>
ha scritto:
… ***@***.**** commented on this pull request.
------------------------------
In
rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/SymbolTable.kt
<#696 (comment)>:
> @@ -36,7 +36,24 @@ class SymbolTable : ISymbolTable {
if (MainExecutionContext.isLoggingEnabled) getWithLogging(dataName) else getInternal(dataName)
override fun dataDefinitionByName(dataName: String): AbstractDataDefinition? {
I'll provide it. In this case the only change is the addition about
searching for field of DS declared as not QUALIFIED.
—
Reply to this email directly, view it on GitHub
<#696 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJR622UH2RJ2M2JCJCQYUYD2MHPRNAVCNFSM6AAAAABVUWKONGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZRG43TGMRXGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
[image: smeup] <https://www.smeup.com>
Marco Lanari
R&D Department - Developer
Office: 0521940611
www.smeup.com
*SMEUP LAB SRL*
Via Carra, 8 - 43122 Parma (PR)
|
lanarimarco
requested changes
Jan 27, 2025
rpgJavaInterpreter-core/src/test/kotlin/com/smeup/rpgparser/interpreter/SymbolTableTest.kt
Show resolved
Hide resolved
rpgJavaInterpreter-core/src/test/kotlin/com/smeup/rpgparser/utils/DbMock.kt
Show resolved
Hide resolved
lanarimarco
approved these changes
Jan 27, 2025
This pr has been reverted caused regressions |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work solves the fields concurrence between a File, imported with
F
specification, and a DS which usesEXTNAME
to the same file. By considering this little snippet:every evaluation of a File field is for DS field too.
Technical notes
On Jariko File and DS fields declared as that snippet are separated. So, we have decided to remove from root of Data Definitions, then for Global Symbol Table, those File Definitions if are already defined on a DS which uses
EXTNAME
for same file. Thanks to #694, the DS declared with that keyword are notQUALIFIED
; so, is possible to access to a field without dot notation.Also, in this work there is an improvement for test by adding the capability to populate DB table with some value. This is useful for
MUDRNRAPU00189
test.Finally, this work introduces a new test suite dedicated for Symbol Table.
Related to #LS25000142
Checklist:
./gradlew ktlintCheck
)../gradlew check
).docs
directory.