Skip to content

Bugfix/LS24003795/Incongruous definifion between two DS by using API #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

davidepalladino-apuliasoft
Copy link
Collaborator

Description

This work is related to Jariko, for the logic of /API directive.

Technical notes

We consider this program:

      /COPY QILEGEN,£PDS
      /COPY QILEGEN,£C5PDS

      /API QILEGEN,MUDRNRAPU001101_API      
     ...

and the program added with /API directive:

     D/COPY QILEGEN,£PDS

Under the hood we have, from main program, a DS (by £PDS) with another fields (by £C5PDS); on the other hand, the program imported by using API declares the same DS (by £PDS) without additions. So, the fix has been made thanks to these assertions:

  • API program still works with its definition because the same DS (without additions) is declared from main program (with additions);
  • the DS enhanced of main program still works because is the only one considered during the execution.

This is a work of 22nd August 2024.

Related to #LS24003795

Checklist:

  • If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
  • There are tests for this feature.
  • RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
  • The code follows Kotlin conventions (run ./gradlew ktlintCheck).
  • The code passes all tests (run ./gradlew check).
  • Relevant documentation is included in the docs directory.

@lanarimarco lanarimarco merged commit 081a344 into develop Feb 7, 2025
1 check passed
@lanarimarco lanarimarco deleted the bugfix/LS24003795/incongruou-definifion-between-two-ds-by-using-api branch February 7, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants