Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Side Rendering Prototype #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Server Side Rendering Prototype #102

wants to merge 1 commit into from

Conversation

smfoote
Copy link
Owner

@smfoote smfoote commented Jul 13, 2015

Server Side Rendering for Tornado using simple-dom. This is a prototype, and not meant to be merged (yet). It is not fully tested, but seems to be working pretty well so far.

Known issues:

  • Promises don't work (because the rendering doesn't wait for promises to resolve)
  • Because Promises don't work, Node Attributes don't work.

@@ -29,6 +34,7 @@
"grunt-peg": "^1.5.0",
"load-grunt-tasks": "^3.1.0",
"pegjs": "^0.8.0",
"simple-dom": "^0.2.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this'll be a real dependency no?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Thanks.

@prashn64
Copy link
Collaborator

Look good, I'll just have to set up some testing stuffs so we can figure out the promises.

@smfoote smfoote mentioned this pull request Jul 21, 2015
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants